mirrors/pikasTech-unidesk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #1277 from pikasTech/fix/1274-dashboard-verify-empty-check-rows

Browse Source 
fix: allow healthy sentinel dashboard rows
This commit is contained in:
Lyon
2026-06-30 09:35:46 +08:00
committed by GitHub
parent e5c7bb6689 6fb7505951
commit 25b6ca5910
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts/src/hwlab-node-web-sentinel-p5.ts
+5 -4
View File
@@ -488,6 +488,7 @@ const dom = await page.evaluate(async ({ expectedRoutePrefix, expectedSentinelId
};
};
const latestDetailSummary = summarizeRows(latestDetailRows);
const expectsAlertRows = latestDetailSummary.alertTypeCount > 0;
latestRunCounts.typeCount = latestDetailSummary.typeCount;
latestRunCounts.error = latestDetailSummary.errorTypeCount;
latestRunCounts.warning = latestDetailSummary.warningTypeCount;
@@ -537,6 +538,7 @@ const dom = await page.evaluate(async ({ expectedRoutePrefix, expectedSentinelId
alertSamples: numberValue(checksPanel?.getAttribute("data-check-alert-samples")),
visibleRowCount: document.querySelectorAll("[data-check-row='true']").length,
visibleAlertSamples: numberValue(checksPanel?.getAttribute("data-visible-check-alert-samples")),
expectsAlertRows,
matchesLatestRun: false,
matchesRunDetail: false,
belowWorkspace: Boolean(workspaceRect && checksRect && checksRect.top >= workspaceRect.bottom - 2),
@@ -892,9 +894,7 @@ const ok = !navigationError
&& dom.scopeLabels?.historicalSamples === true
&& (dom.trendDotCount === 0 || (dom.trendTooltip?.visible === true && dom.trendTooltip?.hasValues === true && dom.trendTooltip?.hasTime === true))
&& dom.trendPanelCompact?.ok === true
&& dom.checkRows > 0
&& dom.checkDialog?.opened === true
&& dom.checkDialog?.large === true
&& (dom.checkScope?.expectsAlertRows !== true || (dom.checkRows > 0 && dom.checkDialog?.opened === true && dom.checkDialog?.large === true))
&& dom.badCardTitleCount === 0
&& dom.badCardBodyCount === 0
&& dom.timelineVisible === true
@@ -1414,8 +1414,9 @@ function renderDashboardResult(result: Record<string, unknown>): string {
checkScope.matchesRunDetail ?? "-",
]]),
"",
table(["CHECK_VISIBLE_ROWS", "CHECK_VISIBLE_ALERT", "RUN_TAG_ERR", "RUN_TAG_ALERT", "RUN_TAG_MATCH", "BELOW_WORKSPACE", "FULL_WIDTH"], [[
table(["CHECK_VISIBLE_ROWS", "EXPECT_ALERT_ROWS", "CHECK_VISIBLE_ALERT", "RUN_TAG_ERR", "RUN_TAG_ALERT", "RUN_TAG_MATCH", "BELOW_WORKSPACE", "FULL_WIDTH"], [[
checkScope.visibleRowCount ?? "-",
checkScope.expectsAlertRows ?? "-",
checkScope.visibleAlertSamples ?? "-",
selectedRunTags.error ?? "-",
selectedRunTags.warning ?? "-",