diff --git a/scripts/src/hwlab-node-web-sentinel-p5.ts b/scripts/src/hwlab-node-web-sentinel-p5.ts index d896ba12..ba62bb9b 100644 --- a/scripts/src/hwlab-node-web-sentinel-p5.ts +++ b/scripts/src/hwlab-node-web-sentinel-p5.ts @@ -488,6 +488,7 @@ const dom = await page.evaluate(async ({ expectedRoutePrefix, expectedSentinelId }; }; const latestDetailSummary = summarizeRows(latestDetailRows); + const expectsAlertRows = latestDetailSummary.alertTypeCount > 0; latestRunCounts.typeCount = latestDetailSummary.typeCount; latestRunCounts.error = latestDetailSummary.errorTypeCount; latestRunCounts.warning = latestDetailSummary.warningTypeCount; @@ -537,6 +538,7 @@ const dom = await page.evaluate(async ({ expectedRoutePrefix, expectedSentinelId alertSamples: numberValue(checksPanel?.getAttribute("data-check-alert-samples")), visibleRowCount: document.querySelectorAll("[data-check-row='true']").length, visibleAlertSamples: numberValue(checksPanel?.getAttribute("data-visible-check-alert-samples")), + expectsAlertRows, matchesLatestRun: false, matchesRunDetail: false, belowWorkspace: Boolean(workspaceRect && checksRect && checksRect.top >= workspaceRect.bottom - 2), @@ -892,9 +894,7 @@ const ok = !navigationError && dom.scopeLabels?.historicalSamples === true && (dom.trendDotCount === 0 || (dom.trendTooltip?.visible === true && dom.trendTooltip?.hasValues === true && dom.trendTooltip?.hasTime === true)) && dom.trendPanelCompact?.ok === true - && dom.checkRows > 0 - && dom.checkDialog?.opened === true - && dom.checkDialog?.large === true + && (dom.checkScope?.expectsAlertRows !== true || (dom.checkRows > 0 && dom.checkDialog?.opened === true && dom.checkDialog?.large === true)) && dom.badCardTitleCount === 0 && dom.badCardBodyCount === 0 && dom.timelineVisible === true @@ -1414,8 +1414,9 @@ function renderDashboardResult(result: Record): string { checkScope.matchesRunDetail ?? "-", ]]), "", - table(["CHECK_VISIBLE_ROWS", "CHECK_VISIBLE_ALERT", "RUN_TAG_ERR", "RUN_TAG_ALERT", "RUN_TAG_MATCH", "BELOW_WORKSPACE", "FULL_WIDTH"], [[ + table(["CHECK_VISIBLE_ROWS", "EXPECT_ALERT_ROWS", "CHECK_VISIBLE_ALERT", "RUN_TAG_ERR", "RUN_TAG_ALERT", "RUN_TAG_MATCH", "BELOW_WORKSPACE", "FULL_WIDTH"], [[ checkScope.visibleRowCount ?? "-", + checkScope.expectsAlertRows ?? "-", checkScope.visibleAlertSamples ?? "-", selectedRunTags.error ?? "-", selectedRunTags.warning ?? "-",