mirrors/pikasTech-unidesk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: deduplicate sentinel reclassified findings

Browse Source
This commit is contained in:
Codex
2026-07-06 17:22:19 +00:00
parent bd8e844af6
commit 97fe9c9c6f
2 changed files with 17 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts/src/hwlab-node-web-sentinel-p5.ts
+9 -3
View File
@@ -366,8 +366,12 @@ function offlineQuickVerifyReclassify(state: SentinelCicdState, run: Record<stri
function reclassifySentinelReportFindings(state: SentinelCicdState, run: Record<string, unknown>, findings: readonly Record<string, unknown>[]): Record<string, unknown>[] {
const hasObserverCommandFailure = findings.some((item) => sentinelReportFindingIdentityCandidates(item).includes("observer-command-failed"));
const hasObserverCommandFailureEvidence = findings.some((item) => sentinelReportFindingIdentityCandidates(item).includes("observer-command-failed") && hasCommandFailureEvidence(item));
const catalog = sentinelReportCheckCatalogById(state);
return findings.map((item) => enrichSentinelReportFindingWithCatalog(reclassifySentinelReportFinding(rowFailure(run), item, hasObserverCommandFailure), catalog));
return findings
.map((item) => reclassifySentinelReportFinding(rowFailure(run), item, hasObserverCommandFailure, hasObserverCommandFailureEvidence))
.filter((item): item is Record<string, unknown> => item !== null)
.map((item) => enrichSentinelReportFindingWithCatalog(item, catalog));
}
function rowFailure(row: Record<string, unknown>): string | null {
@@ -376,8 +380,10 @@ function rowFailure(row: Record<string, unknown>): string | null {
?? stringAtNullable(record(row.businessStatus), "failure");
}
function reclassifySentinelReportFinding(failure: string | null, item: Record<string, unknown>, hasObserverCommandFailure: boolean): Record<string, unknown> {
function reclassifySentinelReportFinding(failure: string | null, item: Record<string, unknown>, hasObserverCommandFailure: boolean, hasObserverCommandFailureEvidence: boolean): Record<string, unknown> | null {
const ids = sentinelReportFindingIdentityCandidates(item);
if (ids.includes("observer-command-failure-evidence-missing") && hasObserverCommandFailureEvidence) return null;
if (ids.includes("no-samples-artifact-evidence-missing") && hasObserverCommandFailure) return null;
if (ids.includes("quick-verify-command-sequence-failed")) {
return retagSentinelReportFinding(item, "account-session-command-failed-before-observation", {
summary: "account/session setup command failed before any business turn could be observed.",
@@ -388,7 +394,7 @@ function reclassifySentinelReportFinding(failure: string | null, item: Record<st
nextAction: "Inspect the first failed account/session/workbench command and rerun quick verify after that command succeeds.",
});
}
if (ids.includes("observer-command-failed") && !hasCommandFailureEvidence(item)) {
if (ids.includes("observer-command-failed") && !hasObserverCommandFailureEvidence && !hasCommandFailureEvidence(item)) {
return retagSentinelReportFinding(item, "observer-command-failure-evidence-missing", {
summary: "report says observer control commands failed, but the first failed command evidence is missing.",
rootCause: "observer-command-failure-evidence-missing",
scripts/src/hwlab-node-web-sentinel-service.ts
+8 -3
View File
@@ -1795,9 +1795,12 @@ function canonicalFindingIdentity(config: WebProbeSentinelServiceConfig, item: R
function reclassifyVisibleFindings(config: WebProbeSentinelServiceConfig, row: Record<string, unknown>, findings: readonly Record<string, unknown>[], limit: number): readonly Record<string, unknown>[] {
const hasObserverCommandFailure = findings.some((item) => findingIdentityCandidates(item).includes("observer-command-failed"));
const hasObserverCommandFailureEvidence = findings.some((item) => findingIdentityCandidates(item).includes("observer-command-failed") && hasCommandFailureEvidence(item));
const failure = stringOrNull(record(row.summary).failure) ?? stringOrNull(row.failure) ?? stringOrNull(record(row.businessStatus).failure);
return findings
.map((item) => enrichFindingWithCheck(config, reclassifyVisibleFinding(item, failure, hasObserverCommandFailure)))
.map((item) => reclassifyVisibleFinding(item, failure, hasObserverCommandFailure, hasObserverCommandFailureEvidence))
.filter((item): item is Record<string, unknown> => item !== null)
.map((item) => enrichFindingWithCheck(config, item))
.slice(0, limit);
}
@@ -1817,8 +1820,10 @@ function findingIdentityCandidates(item: Record<string, unknown>): readonly stri
return [...new Set(candidates.filter((value): value is string => value !== null))];
}
function reclassifyVisibleFinding(item: Record<string, unknown>, failure: string | null, hasObserverCommandFailure: boolean): Record<string, unknown> {
function reclassifyVisibleFinding(item: Record<string, unknown>, failure: string | null, hasObserverCommandFailure: boolean, hasObserverCommandFailureEvidence: boolean): Record<string, unknown> | null {
const ids = findingIdentityCandidates(item);
if (ids.includes("observer-command-failure-evidence-missing") && hasObserverCommandFailureEvidence) return null;
if (ids.includes("no-samples-artifact-evidence-missing") && hasObserverCommandFailure) return null;
if (ids.includes("quick-verify-command-sequence-failed")) {
return retagVisibleFinding(item, "account-session-command-failed-before-observation", {
summary: "account/session setup command failed before any business turn could be observed.",
@@ -1829,7 +1834,7 @@ function reclassifyVisibleFinding(item: Record<string, unknown>, failure: string
nextAction: "Inspect the first failed account/session/workbench command and rerun quick verify after that command succeeds.",
});
}
if (ids.includes("observer-command-failed") && !hasCommandFailureEvidence(item)) {
if (ids.includes("observer-command-failed") && !hasObserverCommandFailureEvidence && !hasCommandFailureEvidence(item)) {
return retagVisibleFinding(item, "observer-command-failure-evidence-missing", {
summary: "report says observer control commands failed, but the first failed command evidence is missing.",
rootCause: "observer-command-failure-evidence-missing",