mirrors/pikasTech-unidesk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: avoid blocking sentinel on non-red quick verify findings

Browse Source
This commit is contained in:
Codex
2026-06-26 07:50:11 +00:00
parent 08470168f8
commit c4059b13d7
1 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts/src/hwlab-node-web-sentinel-cicd.ts
+10 -3
View File
@@ -1705,7 +1705,9 @@ function runSentinelQuickVerify(state: SentinelCicdState, reason: string, timeou
const artifactSummaryRecord = record(artifactSummary);
const artifactFindings = Array.isArray(artifactSummaryRecord.findings) ? artifactSummaryRecord.findings.map(record) : [];
const findings = mergeFindingRecords(artifactFindings, controlFindings);
const ok = analysis.ok && record(artifactSummary).ok === true && controlFindings.length === 0;
const blockingFindings = findings.filter(isQuickVerifyBlockingFinding);
const analysisWarnings = analysis.ok ? [] : ["quick verify analyze command returned non-zero but a readable analysis artifact was produced; targetValidation is using artifact severity plus control blockers."];
const ok = record(artifactSummary).ok === true && controlFindings.length === 0 && blockingFindings.length === 0;
return recordQuickVerify(state, {
ok,
runId,
@@ -1718,7 +1720,7 @@ function runSentinelQuickVerify(state: SentinelCicdState, reason: string, timeou
reportJsonSha256: stringAtNullable(artifactSummary, "reportJsonSha256"),
findingCount: findings.length,
artifactCount: numberAtNullable(artifactSummary, "artifactCount") ?? 0,
failure: controlFindings.length > 0 ? "quick-verify-no-business-turn" : null,
failure: controlFindings.length > 0 ? "quick-verify-no-business-turn" : blockingFindings.length > 0 ? "quick-verify-blocking-findings" : null,
promptSource: prompts.summary,
steps,
analysis: artifactSummary,
@@ -1730,7 +1732,7 @@ function runSentinelQuickVerify(state: SentinelCicdState, reason: string, timeou
findings,
screenshot: record(artifactSummary).screenshot,
publicOrigin: stringAt(state.publicExposure, "publicBaseUrl"),
warnings: elapsedWarnings(),
warnings: mergeWarnings(analysisWarnings, elapsedWarnings()),
valuesRedacted: true,
});
}
@@ -2525,6 +2527,11 @@ function mergeFindingRecords(primary: readonly Record<string, unknown>[], extra:
return merged;
}
function isQuickVerifyBlockingFinding(item: Record<string, unknown>): boolean {
const severity = (stringAtNullable(item, "severity") ?? stringAtNullable(item, "level") ?? "").toLowerCase();
return ["critical", "red", "fatal", "error", "failed", "blocked"].includes(severity);
}
function quickVerifyControlFindings(failure: string | null, promptIndex: number, turnSummary: Record<string, unknown> | null, traceFrame: Record<string, unknown> | null): Record<string, unknown>[] {
const rendered = [
typeof turnSummary?.renderedText === "string" ? turnSummary.renderedText : "",