mirrors/pikasTech-unidesk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(commander): add GPT prompt boundary lint

Browse Source
This commit is contained in:
Codex
2026-05-23 13:24:15 +00:00
parent e2646763c0
commit 77a8c6b878
10 changed files with 434 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts/src/check.ts
+6
View File
@@ -28,11 +28,13 @@ const syntaxFiles = [
"scripts/src/e2e.ts",
"scripts/src/help.ts",
"scripts/src/commander.ts",
"scripts/src/commander-prompt-lint.ts",
"scripts/src/recovery-guardrails.ts",
"scripts/src/server-cleanup.ts",
"scripts/src/remote.ts",
"scripts/host-codex-commander-contract-test.ts",
"scripts/host-codex-commander-no-daemon-smoke-contract-test.ts",
"scripts/host-codex-commander-prompt-lint-contract-test.ts",
"scripts/host-codex-commander-skeleton-contract-test.ts",
"scripts/auth-broker-contract-test.ts",
"scripts/code-queue-cli-disclosure-contract-test.ts",
@@ -335,6 +337,7 @@ export function runChecks(config: UniDeskConfig, options: CheckOptions = default
fileItem("src/components/microservices/host-codex-commander/src/redaction.ts"),
fileItem("src/components/microservices/host-codex-commander/src/state.ts"),
fileItem("src/components/microservices/code-queue-mgr/src/prompt-observation.ts"),
fileItem("scripts/src/commander-prompt-lint.ts"),
fileItem("scripts/src/deploy.ts"),
fileItem("scripts/code-queue-issue3-regression-test.ts"),
fileItem("scripts/code-queue-liveness-diagnostics-test.ts"),
@@ -355,6 +358,7 @@ export function runChecks(config: UniDeskConfig, options: CheckOptions = default
fileItem("scripts/code-queue-commander-view-contract-test.ts"),
fileItem("scripts/host-codex-commander-skeleton-contract-test.ts"),
fileItem("scripts/host-codex-commander-no-daemon-smoke-contract-test.ts"),
fileItem("scripts/host-codex-commander-prompt-lint-contract-test.ts"),
fileItem("scripts/provider-runner-triage-contract-test.ts"),
fileItem("scripts/ssh-argv-guidance-contract-test.ts"),
fileItem("scripts/src/provider-triage.ts"),
@@ -408,6 +412,7 @@ export function runChecks(config: UniDeskConfig, options: CheckOptions = default
items.push(commandItem("code-queue:commander-view-contract", ["bun", "scripts/code-queue-commander-view-contract-test.ts"], 30_000));
items.push(commandItem("host-codex-commander:skeleton-contract", ["bun", "scripts/host-codex-commander-skeleton-contract-test.ts"], 30_000));
items.push(commandItem("host-codex-commander:no-daemon-smoke-contract", ["bun", "scripts/host-codex-commander-no-daemon-smoke-contract-test.ts"], 30_000));
items.push(commandItem("host-codex-commander:prompt-lint-contract", ["bun", "scripts/host-codex-commander-prompt-lint-contract-test.ts"], 30_000));
items.push(commandItem("provider:runner-triage-contract", ["bun", "scripts/provider-runner-triage-contract-test.ts"], 30_000));
items.push(commandItem("ssh:argv-guidance-contract", ["bun", "scripts/ssh-argv-guidance-contract-test.ts"], 30_000));
items.push(commandItem("deploy:artifact-matrix-contract", ["bun", "scripts/deploy-artifact-matrix-contract-test.ts"], 90_000));
@@ -449,6 +454,7 @@ export function runChecks(config: UniDeskConfig, options: CheckOptions = default
items.push(skippedItem("code-queue:commander-view-contract", "Code Queue commander view contract is opt-in with script checks", "--scripts-typecheck or --full"));
items.push(skippedItem("host-codex-commander:skeleton-contract", "host Codex commander skeleton contract is opt-in with script checks", "--scripts-typecheck or --full"));
items.push(skippedItem("host-codex-commander:no-daemon-smoke-contract", "host Codex commander no-daemon smoke contract is opt-in with script checks", "--scripts-typecheck or --full"));
items.push(skippedItem("host-codex-commander:prompt-lint-contract", "host Codex commander prompt boundary lint contract is opt-in with script checks", "--scripts-typecheck or --full"));
items.push(skippedItem("provider:runner-triage-contract", "Provider runner triage contract is opt-in with script checks", "--scripts-typecheck or --full"));
items.push(skippedItem("ssh:argv-guidance-contract", "SSH argv guidance and failure hint contract is opt-in with script checks", "--scripts-typecheck or --full"));
items.push(skippedItem("deploy:artifact-matrix-contract", "deploy artifact matrix contract is opt-in with script checks", "--scripts-typecheck or --full"));
scripts/src/commander-prompt-lint.ts
+245
View File
@@ -0,0 +1,245 @@
import { readFileSync } from "node:fs";
export type CommanderPromptLintKind = "gpt55-pr";
export type CommanderPromptLintRiskLevel = "low" | "medium" | "high";
interface ClauseCheck {
id: string;
label: string;
required: boolean;
matched: boolean;
severity: "medium" | "high";
suggestion: string;
}
export interface CommanderPromptLintResult {
ok: boolean;
kind: CommanderPromptLintKind;
missingClauses: string[];
riskLevel: CommanderPromptLintRiskLevel;
suggestedPatchSnippet: string;
promptShape: {
chars: number;
lines: number;
textEchoed: false;
};
policy: {
advisoryOnly: true;
mutatesScheduler: false;
changesCodexSubmitDefault: false;
printsPromptText: false;
supportedInputs: Array<"--stdin" | "--prompt-file">;
reference: string;
};
}
interface ParsedPromptLintArgs {
kind: CommanderPromptLintKind;
prompt: string;
}
const gpt55PrSnippet = [
"GPT-5.5 runner boundary:",
"- You may create/update the branch and PR, resolve conflicts, rebase/update from the target branch, and self-merge/close an ordinary PR when checks pass and the task boundary is satisfied.",
"- You may use repo-owned CI/CD, publish, or equivalent controlled build paths to build/publish DEV images or artifacts, and must report commit, image tag, digest, artifact report, and validation evidence.",
"- DEV deploy apply, rollout, and live health verification are owned by the host commander unless this prompt explicitly contains ROLLOUT_OK.",
"- Without explicit ROLLOUT_OK, do not acquire the DEV CD lock, run deploy apply, perform rollout/restart, or compete with host commander live verification.",
"- Forbidden: PROD mutation, reading or printing secrets, manual database writes, destructive rollback, Code Queue backend/scheduler restart, or interrupt/cancel running tasks unless explicitly authorized.",
].join("\n");
function hasFlag(args: string[], flag: string): boolean {
return args.includes(flag);
}
function optionValue(args: string[], names: string[]): string | undefined {
for (const name of names) {
const index = args.indexOf(name);
if (index === -1) continue;
const value = args[index + 1];
if (value === undefined || value.startsWith("--")) throw new Error(`${name} requires a value`);
return value;
}
return undefined;
}
function assertKnownOptions(args: string[]): void {
const flags = new Set(["--stdin"]);
const valueOptions = new Set(["--kind", "--prompt-file", "--file"]);
for (let index = 0; index < args.length; index += 1) {
const arg = args[index] ?? "";
if (!arg.startsWith("--")) throw new Error(`commander prompt-lint does not accept positional prompt text; use --stdin or --prompt-file`);
if (flags.has(arg)) continue;
if (valueOptions.has(arg)) {
index += 1;
if (index >= args.length) throw new Error(`${arg} requires a value`);
continue;
}
throw new Error(`unknown commander prompt-lint option: ${arg}`);
}
}
function parseKind(raw: string | undefined): CommanderPromptLintKind {
const kind = raw ?? "gpt55-pr";
if (kind !== "gpt55-pr") throw new Error(`unsupported commander prompt-lint kind: ${kind}`);
return kind;
}
function readPromptFromArgs(args: string[]): string {
const promptFile = optionValue(args, ["--prompt-file", "--file"]);
const promptStdin = hasFlag(args, "--stdin");
const sources = [promptFile !== undefined, promptStdin].filter(Boolean).length;
if (sources !== 1) throw new Error("commander prompt-lint requires exactly one prompt source: --prompt-file or --stdin");
const prompt = promptFile !== undefined
? (promptFile === "-" ? readFileSync(0, "utf8") : readFileSync(promptFile, "utf8"))
: readFileSync(0, "utf8");
if (prompt.trim().length === 0) throw new Error("commander prompt-lint prompt must not be empty");
return prompt;
}
export function parseCommanderPromptLintArgs(args: string[]): ParsedPromptLintArgs {
assertKnownOptions(args);
return {
kind: parseKind(optionValue(args, ["--kind"])),
prompt: readPromptFromArgs(args),
};
}
function any(patterns: RegExp[], prompt: string): boolean {
return patterns.some((pattern) => pattern.test(prompt));
}
function rolloutOkPresent(prompt: string): boolean {
return /\bROLLOUT_OK\b/u.test(prompt);
}
function gpt55PrClauseChecks(prompt: string): ClauseCheck[] {
const prAuthorization = any([
/\bPR\b[^\n。]{0,120}(?:create|update|push|branch|merge|close|rebase|conflict)/iu,
/(?:创建|更新|push|提交|合并|关闭|rebase|解决冲突)[^\n。]{0,80}\bPR\b/iu,
], prompt) && any([
/self[- ]?(?:merge|close)|自行(?:合并|关闭|收口)|自合并|自收口/iu,
/merge\/close|合并\/关闭/iu,
], prompt) && any([
/\brebase\b|\bupdate\b|解决冲突|更新(?:目标|base|master|分支)/iu,
], prompt);
const artifactAuthorization = any([
/\b(?:build|publish)\b[^\n。]{0,80}\b(?:artifact|image|DEV image|镜像|制品)\b/iu,
/\b(?:artifact|image|镜像|制品)\b[^\n。]{0,80}\b(?:build|publish|tag|digest|构建|发布)\b/iu,
/(?:构建|发布)[^\n。]{0,80}(?:镜像|制品|artifact|image)/iu,
], prompt) && any([
/\b(?:tag|digest|artifact report|image tag)\b/iu,
/(?:镜像\s*tag|digest|制品报告|artifact report)/iu,
], prompt);
const hostOwnsDevRollout = any([
/DEV[^\n。]{0,120}(?:deploy apply|rollout|live health|live verification)[^\n。]{0,120}(?:host commander|commander|host|统一执行|统一处理|统一复验)/iu,
/(?:host commander|commander|host|指挥官)[^\n。]{0,120}DEV[^\n。]{0,120}(?:deploy apply|rollout|live health|live verification|发布|上线|复验)/iu,
/DEV[^\n。]{0,80}(?:发布|上线|rollout|复验)[^\n。]{0,80}(?:host|commander|指挥官|统一)/iu,
], prompt);
const forbidsRunnerRolloutUnlessOk = any([
/unless[^\n。]{0,80}\bROLLOUT_OK\b/iu,
/未显式[^\n。]{0,60}\bROLLOUT_OK\b[^\n。]{0,80}(?:不要|不得|禁止|do not|don't|must not)/iu,
/\bROLLOUT_OK\b[^\n。]{0,80}(?:才|unless|only if|explicit)/iu,
], prompt) && any([
/(?:do not|don't|must not|禁止|不要|不得)[^\n。]{0,100}(?:DEV CD lock|deploy apply|rollout|live health|rollout restart|竞争|抢)/iu,
/(?:DEV CD lock|deploy apply|rollout|live health|rollout restart|竞争|抢)[^\n。]{0,100}(?:do not|don't|must not|禁止|不要|不得)/iu,
], prompt);
const prodForbidden = any([
/(?:禁止|不要|不得|must not|do not|don't|\bno\b|forbid|forbidden)[^\n。]{0,80}(?:PROD|prod|production|生产)/iu,
/(?:PROD|prod|production|生产)[^\n。]{0,80}(?:禁止|不要|不得|must not|do not|don't|\bno\b|forbid|forbidden|not allowed)/iu,
], prompt);
const secretForbidden = any([
/(?:禁止|不要|不得|must not|do not|don't|\bno\b|forbid|forbidden)[^\n。]{0,80}(?:secret|token|credential|密钥|凭证)/iu,
/(?:secret|token|credential|密钥|凭证)[^\n。]{0,80}(?:禁止|不要|不得|must not|do not|don't|\bno\b|forbid|forbidden|not allowed|读取|打印)/iu,
], prompt);
const dbForbidden = any([
/(?:禁止|不要|不得|must not|do not|don't|\bno\b|forbid|forbidden)[^\n。]{0,80}(?:database|DB|数据库)/iu,
/(?:database|DB|数据库)[^\n。]{0,80}(?:manual|手工|patch|write|写入|禁止|不要|不得|must not|do not|don't|\bno\b)/iu,
], prompt);
const rollbackForbidden = any([
/(?:禁止|不要|不得|must not|do not|don't|\bno\b|forbid|forbidden)[^\n。]{0,80}(?:destructive rollback|破坏性回滚|回滚)/iu,
/(?:destructive rollback|破坏性回滚)[^\n。]{0,80}(?:禁止|不要|不得|must not|do not|don't|\bno\b|forbid|forbidden|not allowed)/iu,
], prompt);
return [
{
id: "pr-self-merge-rebase-authorization",
label: "PR/自合并/rebase/update 授权文本",
required: true,
matched: prAuthorization,
severity: "high",
suggestion: "明确授权 runner 创建/更新 PR、rebase/update/解决冲突，并在普通 PR 满足任务边界和检查通过时自合并/关闭。",
},
{
id: "artifact-build-publish-authorization",
label: "build/publish artifact 授权文本",
required: true,
matched: artifactAuthorization,
severity: "high",
suggestion: "明确授权使用 repo-owned CI/CD 或受控构建路径发布 DEV image/artifact，并要求回报 tag、digest 和 artifact report。",
},
{
id: "host-owned-dev-rollout",
label: "DEV deploy apply/rollout/live verification 由 host 统一执行文本",
required: true,
matched: hostOwnsDevRollout,
severity: "high",
suggestion: "写明 DEV deploy apply、rollout 和 live health verification 默认由 host commander 统一执行。",
},
{
id: "runner-rollout-forbidden-without-rollout-ok",
label: "未显式 ROLLOUT_OK 时禁止 runner rollout",
required: true,
matched: forbidsRunnerRolloutUnlessOk,
severity: "high",
suggestion: "写明未显式包含 ROLLOUT_OK 时，runner 不得抢 DEV CD lock、deploy apply、rollout 或 live verification。",
},
{
id: "prod-secret-db-rollback-boundary",
label: "PROD/secret/DB/破坏性回滚边界",
required: true,
matched: prodForbidden && secretForbidden && dbForbidden && rollbackForbidden,
severity: "high",
suggestion: "同时禁止 PROD mutation、密钥读取/打印、数据库手工写入和破坏性回滚。",
},
];
}
export function lintCommanderPrompt(prompt: string, kind: CommanderPromptLintKind = "gpt55-pr"): CommanderPromptLintResult {
const clauses = gpt55PrClauseChecks(prompt);
const missingClauses = clauses.filter((clause) => clause.required && !clause.matched).map((clause) => clause.id);
const highMissing = clauses.some((clause) => clause.severity === "high" && !clause.matched);
const rolloutOk = rolloutOkPresent(prompt);
const riskLevel: CommanderPromptLintRiskLevel = missingClauses.length === 0
? rolloutOk ? "medium" : "low"
: highMissing ? "high" : "medium";
return {
ok: missingClauses.length === 0,
kind,
missingClauses,
riskLevel,
suggestedPatchSnippet: missingClauses.length === 0 ? "" : gpt55PrSnippet,
promptShape: {
chars: prompt.length,
lines: prompt.split(/\r\n|\r|\n/u).length,
textEchoed: false,
},
policy: {
advisoryOnly: true,
mutatesScheduler: false,
changesCodexSubmitDefault: false,
printsPromptText: false,
supportedInputs: ["--stdin", "--prompt-file"],
reference: "docs/reference/host-codex-commander.md",
},
};
}
export function runCommanderPromptLintCommand(args: string[]): CommanderPromptLintResult {
const options = parseCommanderPromptLintArgs(args);
return lintCommanderPrompt(options.prompt, options.kind);
}
scripts/src/commander.ts
+3
View File
@@ -1,6 +1,7 @@
import { buildCommanderApprovalNotificationDraft, commanderApprovalNotificationPathUnavailable } from "../../src/components/microservices/host-codex-commander/src/approval-notification";
import { commanderContract as hostCommanderContract, commanderHighRiskActions as highRiskActions } from "../../src/components/microservices/host-codex-commander/src/contract";
import { redactText } from "../../src/components/microservices/host-codex-commander/src/redaction";
import { runCommanderPromptLintCommand } from "./commander-prompt-lint";
const requiredDryRunMessage = "This host Codex commander skeleton only supports dry-run planning; live daemon/control operations are not implemented.";
@@ -36,6 +37,7 @@ function commanderHelp(): Record<string, unknown> {
"bun scripts/cli.ts commander plan --dry-run [--session-id id]",
"bun scripts/cli.ts commander smoke --dry-run [--session-id id]",
"bun scripts/cli.ts commander approval request --action <action> --dry-run [--reason text] [--task-id id]",
"bun scripts/cli.ts commander prompt-lint --kind gpt55-pr (--prompt-file <file>|--stdin)",
],
highRiskActions,
reference: "docs/reference/host-codex-commander.md",
@@ -494,6 +496,7 @@ export function runCommanderCommand(args: string[]): Record<string, unknown> {
if (sub === "plan") return commanderPlan(args.slice(1));
if (sub === "smoke") return commanderSmoke(args.slice(1));
if (sub === "approval" && second === "request") return commanderApprovalRequest(args.slice(2));
if (sub === "prompt-lint") return runCommanderPromptLintCommand(args.slice(1)) as unknown as Record<string, unknown>;
return {
ok: false,
error: "unsupported-command",
scripts/src/help.ts
+12 -3
View File
@@ -47,7 +47,7 @@ export function rootHelp(): unknown {
{ command: "artifact-registry plan|render|status|health|install|deploy-backend-core|deploy-service", description: "Manage the D601 host-managed CNCF Distribution registry and run pull-only artifact CD for supported services, including D601 direct, k3s-managed, and code-queue dev-only consumers." },
{ command: "auth-broker contract|health --dry-run|credential-request --dry-run|pr-preflight --dry-run", description: "Inspect the P0 Rust auth broker and CLI adapter contract without reading token values, writing GitHub, or starting services." },
{ command: "gh preflight|auth|issue|pr", description: "Run safe GitHub issue and PR CRUD/lifecycle operations through REST with body-file update replace/append, comment delete, token diagnostics, PR closeout preflight, hard delete unsupported, and merge blocked." },
{ command: "commander contract|plan --dry-run|smoke --dry-run|approval request --dry-run", description: "Host Codex commander skeleton contract, no-daemon smoke plan, and dry-run approval preview; generates <=200 char Chinese ClaudeQQ drafts plus backend-core proxy command without live bridges or message sends." },
{ command: "commander contract|plan --dry-run|smoke --dry-run|approval request --dry-run|prompt-lint --kind gpt55-pr", description: "Host Codex commander skeleton contract, no-daemon smoke plan, dry-run approval preview, and advisory GPT-5.5 PR prompt boundary lint without live bridges, message sends, or submit gating." },
{ command: "code-agent-sandbox", description: "Independent Code Agent Sandbox service skeleton for adapter, mode, and credential-boundary diagnostics." },
{ command: "schedule list|get|runs|run|retry-run|delete", description: "Manage backend-core scheduled tasks and run history; schedule run <id> supports --wait-ms N and retry-run reuses the failed run's schedule." },
{ command: "schedule upsert-pgdata-backup [--time HH:MM] [--remote-base /SERVER_DATA/UNIDESK_PG_DATA]", description: "Create or update the daily PGDATA physical backup task that uploads monthly rotated archives to Baidu Netdisk." },
@@ -213,22 +213,31 @@ function providerHelp(): unknown {
function commanderHelp(): unknown {
return {
command: "commander contract|plan|smoke|approval",
command: "commander contract|plan|smoke|approval|prompt-lint",
output: "json",
usage: [
"bun scripts/cli.ts commander contract",
"bun scripts/cli.ts commander plan --dry-run [--session-id id]",
"bun scripts/cli.ts commander smoke --dry-run [--session-id id]",
"bun scripts/cli.ts commander approval request --action <action> --dry-run [--reason text] [--task-id id]",
"bun scripts/cli.ts commander prompt-lint --kind gpt55-pr (--prompt-file <file>|--stdin)",
],
description: "Inspect the local host Codex commander skeleton contract, dry-run planner, no-daemon smoke validation plan, state helpers, trace summary aggregator, and approval draft preview with a backend-core ClaudeQQ proxy command.",
description: "Inspect the local host Codex commander skeleton contract, dry-run planner, no-daemon smoke validation plan, state helpers, trace summary aggregator, approval draft preview, and advisory GPT-5.5 PR prompt boundary lint.",
boundary: [
"the current skeleton is local-only and never attaches to live bridges",
"dry-run commands never open SSH, PTY, or stdio bridges",
"high-risk actions only produce a <=200 char Chinese ClaudeQQ approval draft and notification-path-unavailable blocker",
"authorized future sends must use backend-core /api/microservices/claudeqq/proxy, not local skill or powershell paths",
"prompt-lint is commander advisory output and does not change codex submit default behavior",
"token and secret values must never be printed",
],
promptLint: {
command: "bun scripts/cli.ts commander prompt-lint --kind gpt55-pr --prompt-file <path>",
stdin: "cat prompt.md | bun scripts/cli.ts commander prompt-lint --kind gpt55-pr --stdin",
outputFields: ["ok", "missingClauses", "riskLevel", "suggestedPatchSnippet"],
fullPromptEchoed: false,
gate: "advisory-only; not a business PR gate and not a Code Queue submit admission change",
},
reference: "docs/reference/host-codex-commander.md",
};
}