diff --git a/scripts/src/pikaoa-test-delivery-renderer.test.ts b/scripts/src/pikaoa-test-delivery-renderer.test.ts index e38e2888..d0bc0503 100644 --- a/scripts/src/pikaoa-test-delivery-renderer.test.ts +++ b/scripts/src/pikaoa-test-delivery-renderer.test.ts @@ -99,6 +99,8 @@ describe("PikaOA test PaC renderer", () => { expect(manifest).toContain("pikaoa.unidesk.io/source-commit: __PIKAOA_SOURCE_COMMIT__"); expect(script).toContain('s|__PIKAOA_SOURCE_COMMIT__|$SOURCE_COMMIT|g'); expect(script).toContain("GitOps manifest contains unresolved provenance or image placeholders"); + expect(script).not.toContain("grep -Eq '$(params.revision)"); + expect(script).toContain("grep -Eq '__PIKAOA_SOURCE_COMMIT__|__PIKAOA_(API|WORKER|WEB)_IMAGE__'"); expect(script).toContain("git ls-remote --exit-code --heads"); expect(script).toContain("git -C /workspace/gitops checkout --orphan"); } finally { diff --git a/scripts/src/pikaoa-test-delivery-renderer.ts b/scripts/src/pikaoa-test-delivery-renderer.ts index 51b744e8..94af7c24 100644 --- a/scripts/src/pikaoa-test-delivery-renderer.ts +++ b/scripts/src/pikaoa-test-delivery-renderer.ts @@ -270,7 +270,7 @@ sed -i \\ -e "s|__PIKAOA_WORKER_IMAGE__|$(params.worker-image)|g" \\ -e "s|__PIKAOA_WEB_IMAGE__|$(params.web-image)|g" \\ "$manifest" -if grep -Eq '\$\(params\.revision\)|__PIKAOA_SOURCE_COMMIT__|__PIKAOA_(API|WORKER|WEB)_IMAGE__' "$manifest"; then +if grep -Eq '__PIKAOA_SOURCE_COMMIT__|__PIKAOA_(API|WORKER|WEB)_IMAGE__' "$manifest"; then echo 'GitOps manifest contains unresolved provenance or image placeholders' >&2 exit 6 fi