mirrors/pikasTech-unidesk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: label code queue final response closeout

Browse Source
This commit is contained in:
Codex
2026-05-23 03:04:05 +00:00
parent 6c02cb1655
commit 3f88396ecf
3 changed files with 57 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts/code-queue-supervisor-disclosure-contract-test.ts
+8 -1
View File
@@ -64,7 +64,7 @@ function fixtureResponse(path: string): JsonRecord {
lastAssistantMessage: {
at: "2026-05-22T00:00:00.000Z",
seq: 120,
source: "assistant",
source: "finalResponse",
text: longText(`summary-assistant-${taskId}`, 130),
},
commands: {
@@ -218,10 +218,16 @@ export function runCodeQueueSupervisorDisclosureContract(): JsonRecord {
assertCondition(diagnostics.livenessSummary === undefined, "supervisor diagnostics should omit liveness summary preview by default", diagnostics);
assertCondition(listBudget.truncated === true && typeof listBudget.rawCommand === "string", "diagnostic list budget should disclose raw command", listBudget);
assertCondition(asArray(runningItem.issues).includes("#132"), "supervisor row should expose issue refs for triage", runningItem);
assertCondition(runningItem.status === "running", "fixture running row should keep raw scheduler status", runningItem);
assertCondition(String(runningItem.statusLabel ?? "").includes("awaiting terminal/judge"), "running finalResponse row should expose awaiting terminal/judge label", runningItem);
assertCondition(runningItem.awaitingTerminalJudge === true && runningItem.closeoutState === "awaiting-terminal-or-judge", "running finalResponse row should be marked as not ready for closeout", runningItem);
assertCondition(String(runningItem.closeoutHint ?? "").includes("wait for terminal status and judge"), "running finalResponse row should explain commander interpretation", runningItem);
assertCondition(Number(runningItem.promptChars) > String(runningItem.prompt ?? "").length && runningItem.promptTruncated === true, "supervisor prompt must be a short flat preview with original char count", runningItem);
assertCondition(Number(runningItem.lastChars) > String(runningItem.last ?? "").length && runningItem.lastTruncated === true, "supervisor body must be a short flat preview with original char count", runningItem);
assertCondition(runningItem.commands === undefined && runningItem.promptPreview === undefined && runningItem.lastAssistantMessage === undefined, "supervisor rows must not expose repeated commands or legacy long list fields", runningItem);
assertCondition(asRecord(fullItem.promptPreview).chars !== undefined && fullItem.lastAssistantMessage !== undefined, "full view must retain detailed task row fields", fullItem);
assertCondition(fullItem.status === "running" && String(fullItem.statusLabel ?? "").includes("awaiting terminal/judge"), "full view should keep raw status while exposing derived closeout label", fullItem);
assertCondition(fullItem.awaitingTerminalJudge === true && fullItem.closeoutState === "awaiting-terminal-or-judge", "full view should expose awaiting terminal/judge state", fullItem);
assertCondition(fullTasks.returned === 15, "full view must not inherit supervisor recentCompleted cap", fullTasks);
const budget = asRecord(disclosure.outputBudget);
assertCondition(budget.recentCompletedReturnedLimit === 3 && budget.sectionReturnedLimit === 3, "supervisor must expose output budget metadata", disclosure);
@@ -240,6 +246,7 @@ export function runCodeQueueSupervisorDisclosureContract(): JsonRecord {
"running/unread locally paged",
"split-brain diagnostics capped",
"prompt/body previews bounded",
"running finalResponse rows labeled awaiting terminal/judge",
"drill-down commands preserved",
"full view remains detailed",
],
scripts/src/code-queue.ts
+47 -1
View File
@@ -200,6 +200,11 @@ interface CodexTasksEntry {
taskId: string;
queueId: string | null;
status: string | null;
statusLabel: string | null;
awaitingTerminalJudge?: boolean;
closeoutState?: "awaiting-terminal-or-judge" | "awaiting-judge";
closeoutHint?: string;
finalResponseAt?: unknown;
currentAttempt: number | null;
updatedAt: string | null;
finishedAt: string | null;
@@ -235,6 +240,11 @@ interface CodexTasksSupervisorEntry {
id: string;
queue: string | null;
status: string | null;
statusLabel?: string;
awaitingTerminalJudge?: boolean;
closeoutState?: "awaiting-terminal-or-judge" | "awaiting-judge";
closeoutHint?: string;
finalResponseAt?: unknown;
attempt: number | null;
updatedAt: string | null;
finishedAt?: string | null;
@@ -1983,10 +1993,31 @@ function supervisorLastMessage(summaryLastAssistant: unknown, maxChars: number):
};
}
const awaitingTerminalJudgeHint = "finalResponse is visible while task status is non-terminal; wait for terminal status and judge before closeout.";
function finalResponseAwaitingTerminalStatus(status: string | null, summaryLastAssistant: unknown): {
label: string;
state: "awaiting-terminal-or-judge" | "awaiting-judge";
finalResponseAt: unknown;
} | null {
if (status !== "running" && status !== "judging") return null;
const record = asRecord(summaryLastAssistant);
if (record === null) return null;
if (asString(record.source) !== "finalResponse") return null;
if (asString(record.text).trim().length === 0) return null;
return {
label: status === "judging" ? "judging (awaiting judge)" : "running (awaiting terminal/judge)",
state: status === "judging" ? "awaiting-judge" : "awaiting-terminal-or-judge",
finalResponseAt: record.at ?? null,
};
}
function taskWatchEntry(task: Record<string, unknown>, summary: Record<string, unknown> | null): CodexTasksEntry {
const taskId = asString(task.id);
const summaryCommands = summary === null ? null : asRecord(summary.commands);
const summaryLastAssistant = summary?.lastAssistantMessage ?? task.lastAssistantMessage;
const status = asString(task.status) || null;
const awaitingStatus = finalResponseAwaitingTerminalStatus(status, summaryLastAssistant);
const promptPreview = textPreview(asString(task.displayPrompt ?? task.basePrompt ?? task.prompt), 360);
const showCommand = typeof summary?.cliHint === "string" && summary.cliHint.length > 0
? summary.cliHint
@@ -1999,7 +2030,14 @@ function taskWatchEntry(task: Record<string, unknown>, summary: Record<string, u
return {
taskId,
queueId: asString(task.queueId) || null,
status: asString(task.status) || null,
status,
statusLabel: awaitingStatus?.label ?? status,
...(awaitingStatus === null ? {} : {
awaitingTerminalJudge: true,
closeoutState: awaitingStatus.state,
closeoutHint: awaitingTerminalJudgeHint,
finalResponseAt: awaitingStatus.finalResponseAt,
}),
currentAttempt: typeof task.currentAttempt === "number" && Number.isFinite(task.currentAttempt) ? task.currentAttempt : null,
updatedAt: asString(task.updatedAt) || null,
finishedAt: asString(task.finishedAt) || null,
@@ -2025,6 +2063,7 @@ function taskSupervisorEntry(task: Record<string, unknown>, summary: Record<stri
const taskId = asString(task.id);
const summaryLastAssistant = summary?.lastAssistantMessage ?? task.lastAssistantMessage;
const status = asString(task.status) || null;
const awaitingStatus = finalResponseAwaitingTerminalStatus(status, summaryLastAssistant);
const unreadTerminal = taskUnreadTerminal(task);
const classification = taskClassification(task, summary);
const queuedReason = compactQueuedReason(task.queuedReason);
@@ -2034,6 +2073,13 @@ function taskSupervisorEntry(task: Record<string, unknown>, summary: Record<stri
id: taskId,
queue: asString(task.queueId) || null,
status,
...(awaitingStatus === null ? {} : {
statusLabel: awaitingStatus.label,
awaitingTerminalJudge: true,
closeoutState: awaitingStatus.state,
closeoutHint: awaitingTerminalJudgeHint,
finalResponseAt: awaitingStatus.finalResponseAt,
}),
attempt: typeof task.currentAttempt === "number" && Number.isFinite(task.currentAttempt) ? task.currentAttempt : null,
updatedAt: asString(task.updatedAt) || null,
...(isTerminalTaskStatus(status) ? { finishedAt: asString(task.finishedAt) || null, unreadTerminal } : {}),