mirrors/pikasTech-agentrun
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(v0.1): sanitize session id for PVC name (RFC 1123 subdomain compliance)

Browse Source 
session id 允许任意字符（含下划线/大写/点），但 PVC name 必须符合
RFC 1123 subdomain（小写字母数字 + '-' + '.'，首尾必须 alphanumeric）。

sanitizeSessionIdForPvc 把非法字符替换为 '-'，全空 fallback 到 'default'。
selftest 增加 3 case 覆盖下划线/大写/纯符号。
This commit is contained in:
Codex
2026-06-03 19:47:29 +08:00
parent e8cfa4c692
commit da797c907c
2 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/selftest/cases/10-mgr-session-pvc.ts
+4 -1
View File
@@ -2,7 +2,7 @@ import assert from "node:assert/strict";
import { startManagerServer } from "../../mgr/server.js";
import { MemoryAgentRunStore } from "../../mgr/store.js";
import { ManagerClient } from "../../mgr/client.js";
import { createSessionPvc, deleteSessionPvc, getSessionPvcSummary, refreshSessionPvcSummary, runSessionStorageGc, sessionPvcNameFor } from "../../mgr/session-pvc.js";
import { createSessionPvc, deleteSessionPvc, getSessionPvcSummary, refreshSessionPvcSummary, runSessionStorageGc, sessionPvcNameFor, sanitizeSessionIdForPvc } from "../../mgr/session-pvc.js";
import type { KubectlHandler, SessionPvcOptions } from "../../mgr/session-pvc.js";
import type { SelfTestCase } from "../harness.js";
@@ -32,6 +32,9 @@ const selfTest: SelfTestCase = async () => {
assert.equal(summary.pvcName, sessionPvcNameFor(sessionId));
assert.equal(summary.pvcPhase, "Bound");
assert.equal(summary.codexRolloutSubdir, "sessions");
assert.equal(sessionPvcNameFor("sess_with_underscores_001"), "agentrun-v01-session-sess-with-underscores-001");
assert.equal(sessionPvcNameFor("Sess.UPPER.001"), "agentrun-v01-session-sess-upper-001");
assert.equal(sessionPvcNameFor("---"), "agentrun-v01-session-default");
const after = await store.getSession(sessionId);
assert.equal(after?.storageKind, "pvc");
assert.equal(after?.storagePvcName, summary.pvcName);